Remove duplicate SCSS rules, merge (consecutive) identical selectors. #14520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenvanhal
commented
Mar 19, 2019
| @@ -1,5 +1,4 @@ | |||
| .editor-error-boundary { | |||
| max-width: $content-width; | |||
There was a problem hiding this comment.
Please advise as to which max-width to keep. Currently preserving existing behavior, $content-width appears to be too narrow for this element (cf. #8834)
There was a problem hiding this comment.
svenvanhal
changed the title
aduth
added
[Type] Code Quality
aduth
approved these changes
Apr 24, 2019
| @@ -1,5 +1,4 @@ | |||
| .editor-error-boundary { | |||
| max-width: $content-width; | |||
There was a problem hiding this comment.
aduth
reviewed
Apr 24, 2019
| @@ -1,12 +1,10 @@ | |||
| .wp-block-media-text { | |||
| display: grid; | |||
| } | |||
There was a problem hiding this comment.
It appears this one was resolved separately in #13989, causing the merge conflict. I'll plan to resolve it.
This was referenced Apr 29, 2019
This was referenced Sep 11, 2024
[Snyk] Upgrade @wordpress/postcss-plugins-preset from 1.6.0 to 5.6.0
WontonSam/woocommerce-admin#263
Open
This was referenced Sep 14, 2024
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes a couple of duplicate CSS rules and merges consecutive selectors in the same file, in cases where the rules have (probably) not been separated on purpose, to improve readability and understandability, as well as slightly reducing the filesize.
How has this been tested?
This change has no side effects.
Types of changes
Refactor, non-breaking