Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BlockPreview component to accept multiple Blocks to preview #16033

Merged
merged 14 commits into from
Jul 31, 2019
Merged

Update BlockPreview component to accept multiple Blocks to preview #16033

merged 14 commits into from
Jul 31, 2019

Commits on Jul 30, 2019

  1. export BlockPreview

    @marekhrabe
    marekhrabe committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    d084523 View commit details
    Browse the repository at this point in the history

  2. Update to accept multiple Blocks

    @getdave @marekhrabe
    getdave authored and marekhrabe committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    51e44f1 View commit details
    Browse the repository at this point in the history

  3. Update reusable Blocks preview to use the new single blocks prop

    @getdave @marekhrabe
    getdave authored and marekhrabe committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    17bab95 View commit details
    Browse the repository at this point in the history

  4. Remove unecessary clone of Blocks 

    Not sure why this was introduced.
    @getdave @marekhrabe
    getdave authored and marekhrabe committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    74f4a0c View commit details
    Browse the repository at this point in the history

  5. Remove export. This is being handled in another PR 

    See #16801
    @getdave @marekhrabe
    getdave authored and marekhrabe committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    ad31ffd View commit details
    Browse the repository at this point in the history

  6. Simplify casting to array via lodash

    @getdave @marekhrabe
    getdave authored and marekhrabe committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    078ee6b View commit details
    Browse the repository at this point in the history

  7. Utilise cloneBlocks to safely merge attributes on blocks prop

    @getdave @marekhrabe
    getdave authored and marekhrabe committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    b8493f1 View commit details
    Browse the repository at this point in the history

  8. Spread reusable block initial attrs correctly

    @getdave @marekhrabe
    getdave authored and marekhrabe committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    5117318 View commit details
    Browse the repository at this point in the history

  9. Fix cloneBlock fn to check for innerBlocks before attempting to map 

    The `innerBlocks` of the `block` being cloned can be `undefined`. Therefore, by attempting to map these we trigger an error.

Fixed to introduce existence check before attempting to manipulate innerBlocks.
    @getdave @marekhrabe
    getdave authored and marekhrabe committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    80c105a View commit details
    Browse the repository at this point in the history

  10. Simplify modifying passed block attrs via cloneBlock

    @getdave @marekhrabe
    getdave authored and marekhrabe committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    41b0a99 View commit details
    Browse the repository at this point in the history

  11. Removes unecessary spread operation 

    initalAttributes is already an object so no need to spread into an object.
    @getdave @marekhrabe
    getdave authored and marekhrabe committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    20bc603 View commit details
    Browse the repository at this point in the history

  12. block-preview: ensuring to cast BlockEditorProvider value prop as an … 

    …Array
    @retrofox @marekhrabe
    retrofox authored and marekhrabe committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    d04cf21 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2019

  1. don't call cloneBlock on a non-block object

    @marekhrabe
    marekhrabe committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    2b8f1fb View commit details
    Browse the repository at this point in the history

  2. bring back the old behavior of cloneBlock

    @marekhrabe
    marekhrabe committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    75f9bb0 View commit details
    Browse the repository at this point in the history