Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try removing block breadcrumbs #16506

Closed
wants to merge 3 commits into from
Closed

Try removing block breadcrumbs #16506

wants to merge 3 commits into from

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Jul 10, 2019

As noted in issues like #16334 and #14095 (comment), the block breadcrumbs that currently appear on hover may not be necessary UI elements. This PR gives us an opportunity to test what it's like with them gone.

Before:

Screen Shot 2019-07-10 at 9 20 55 AM

After:

Screen Shot 2019-07-10 at 9 19 51 AM

@kjellr kjellr added Needs Design Feedback Needs general design feedback. Needs Accessibility Feedback Need input from accessibility labels Jul 10, 2019
@kjellr kjellr self-assigned this Jul 10, 2019
@kjellr
Copy link
Contributor Author

kjellr commented Jul 10, 2019

(Also worth noting: even if we decide to remove this from hover, we may not want to remove it entirely since it may be used for things like #16500)

@chrisvanpatten
Copy link
Member

As I noted in #16334 I was originally totally in favor of this change but I've definitely re-evaluated and now think it would be a mistake. If this change goes through, you lose an easy way to discern what type of block you're looking at without selecting the block.

For now while the number of core blocks is relatively low, this might not be a huge problem — after all, it's easy to tell apart a paragraph and image block, for instance. But as the number of third party blocks grows (accelerated by the block editor) I think there is tremendous value in making it easier to identify a block in a more ambient way, which these breadcrumbs currently provide.

@kjellr
Copy link
Contributor Author

kjellr commented Jul 10, 2019

Yeah, I'm not 100% sure that this makes sense either. It could also be that we just need to rethink the display of these breadcrumbs: maybe they're more like standard tooltips for instance.

@paaljoachim
Copy link
Contributor

I kinda like having the block type visible on hover as it quickly gives an overview of the type of block in use.

@mtias
Copy link
Member

mtias commented Jul 26, 2019

@kjellr I think with block navigation mode we might be able to do this #16500. What about as a start if we remove the breadcrumb on nested blocks? I think that is adding a lot of noise and not being super helpful.

@kjellr
Copy link
Contributor Author

kjellr commented Aug 1, 2019

What about as a start if we remove the breadcrumb on nested blocks? I think that is adding a lot of noise and not being super helpful.

Yeah, that could be a good route to try out. I tried it out quickly with CSS, and it definitely helps to reduce the noise a bit.

breadcrumb

We still need to clean up hover states inside these nested blocks (#16820), so let's revisit once that's sorted out too. I'll close this PR in the meantime.

@kjellr kjellr closed this Aug 1, 2019
@kjellr kjellr deleted the try/remove-breadcrumbs branch August 1, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Accessibility Feedback Need input from accessibility Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants