Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try adding some additional padding to the modal component. #16690

Merged
merged 3 commits into from
Aug 2, 2019
Merged

Try adding some additional padding to the modal component. #16690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efda06d
Add additional padding to the modal component.
kjellr Jul 19, 2019
d3419b8
Update block manager padding to match the new modal padding.
kjellr Jul 19, 2019
c58899a
Make ($grid-size * 3) into a variable
kjellr Jul 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions assets/stylesheets/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ $mobile-text-min-font-size: 16px; // Any font size below 16px will cause Mobile
$grid-size-small: 4px;
$grid-size: 8px;
$grid-size-large: 16px;
$grid-size-xlarge: 24px;

// Widths, heights & dimensions
$panel-padding: 16px;
Expand Down
6 changes: 3 additions & 3 deletions packages/components/src/modal/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
.components-modal__header {
box-sizing: border-box;
border-bottom: $border-width solid $light-gray-500;
padding: 0 $grid-size-large;
padding: 0 $grid-size-xlarge;
display: flex;
flex-direction: row;
justify-content: space-between;
Expand All @@ -71,7 +71,7 @@
position: sticky;
top: 0;
z-index: z-index(".components-modal__header");
margin: 0 -#{ $grid-size-large } $grid-size-large;
margin: 0 -#{$grid-size-xlarge} $grid-size-xlarge;

// Rules inside this query are only run by Microsoft Edge.
// Edge has bugs around position: sticky;, so it needs a separate top rule.
Expand Down Expand Up @@ -114,7 +114,7 @@
.components-modal__content {
box-sizing: border-box;
height: 100%;
padding: 0 $grid-size-large $grid-size-large;
padding: 0 $grid-size-xlarge $grid-size-xlarge;

// Rules inside this query are only run by Microsoft Edge.
// This is a companion top padding to the fixed rule in line 77.
Expand Down
8 changes: 4 additions & 4 deletions packages/edit-post/src/components/manage-blocks-modal/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,9 @@
.edit-post-manage-blocks-modal__results {
height: 100%;
overflow: auto;
margin-left: -1 * $grid-size-large;
margin-right: -1 * $grid-size-large;
padding-left: $grid-size-large;
padding-right: $grid-size-large;
margin-left: -$grid-size-xlarge;
margin-right: -$grid-size-xlarge;
padding-left: $grid-size-xlarge;
padding-right: $grid-size-xlarge;
border-top: $border-width solid $light-gray-500;
}