Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra specificity to toolbar position for wide/full blocks #16858

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Aug 1, 2019

Fixes #16837.

At certain breakpoints, the position of the toolbar for wide/full blocks is offset to account for block mover controls. As added in #16579, these styles unnecessarily flow down into innerblock toolbars. This PR adds some extra specificity so that the rules only go into effect for the toolbar of the wide/full block itself.

Before

Screen Shot 2019-08-01 at 9 43 48 AM

Screen Shot 2019-08-01 at 9 48 29 AM

After

Screen Shot 2019-08-01 at 9 38 32 AM

Screen Shot 2019-08-01 at 9 48 54 AM

So that it doesn't apply to innerblock toolbars as well.
@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Aug 1, 2019
@kjellr kjellr self-assigned this Aug 1, 2019
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block toolbars misaligned on desktop for inner blocks within a full width block
2 participants