Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Fix post visibility null password edits. #17210

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Editor: Fix post visibility null password edits. #17210

merged 1 commit into from
Aug 27, 2019

Conversation

epiqueras
Copy link
Contributor

Fixes #17209

Description

This PR fixes the issue described in #17209.

The cause was that an old component incorrectly sets the post's password to null when publishing a post as private without a password. The API does not persist that edit so it would not clear after the response.

How has this been tested?

The expected behavior in #17209 was verified to occur.

Types of Changes

Bug Fix: Stop the post visibility component from setting passwords to null when publishing private posts.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@epiqueras epiqueras added [Type] Bug An existing feature does not function as intended [Package] Editor /packages/editor labels Aug 27, 2019
@epiqueras epiqueras added this to the Gutenberg 6.4 milestone Aug 27, 2019
@epiqueras epiqueras self-assigned this Aug 27, 2019
@gziolo gziolo removed this from the Gutenberg 6.4 milestone Aug 27, 2019
jorgefilipecosta
jorgefilipecosta approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the problem in my tests 👍

@epiqueras epiqueras merged commit a6e85e6 into master Aug 27, 2019
@epiqueras epiqueras deleted the fix/post-visibility-null-edits branch August 27, 2019 19:47
jorgefilipecosta pushed a commit that referenced this pull request Aug 28, 2019
@epiqueras @jorgefilipecosta
Editor: Fix post visibility null password edits. (#17210)
5e70ae6
@talldan talldan mentioned this pull request Aug 29, 2019
Closed
@talldan talldan modified the milestone: Gutenberg 6.4 Aug 29, 2019
@talldan
Copy link
Contributor

talldan commented Aug 29, 2019

Seems like this has introduced a different issue - #17247.

gziolo pushed a commit that referenced this pull request Aug 29, 2019
@epiqueras @gziolo
Editor: Fix post visibility null password edits. (#17210)
3f549ca
gziolo pushed a commit that referenced this pull request Aug 29, 2019
@epiqueras @gziolo
Editor: Fix post visibility null password edits. (#17210)
2291255
@epiqueras epiqueras mentioned this pull request Aug 29, 2019
Merged
5 tasks
@gziolo gziolo added this to the Gutenberg 6.5 milestone Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@talldan talldan Awaiting requested review from talldan

Assignees

@epiqueras epiqueras

Labels
[Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 6.5
Development

Successfully merging this pull request may close these issues.

Private posts/pages triggers unsaved changes warnings
4 participants
@epiqueras @talldan @jorgefilipecosta @gziolo