Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rnmobile] Breadcrumbs #17471

Merged
merged 59 commits into from
Oct 25, 2019
Merged

[rnmobile] Breadcrumbs #17471

merged 59 commits into from
Oct 25, 2019

Commits on Aug 28, 2019

  1. [RNMobile] Native mobile release v1.11.0 (WordPress#17181) 

    * [RNMobile] Fix crash when adding separator

* Build: remove global install of latest npm since we want to use the paired node/npm version (WordPress#17134)

* Build: remove global install of latest npm since we want to use the paired node/npm version
* Also update travis to remove --latest-npm flag

* [RNMobile] Try dark mode (iOS) (WordPress#17067)

* Adding dark mode component implemented on list and list block

* Adding DarkMode handling to RichText, ToolBar and SafeArea

* Mobile: Using DarkMode as HOC

* iOS DarkMode: Modified colors on block list and block container

* iOS DarkMode: Improved Header Toolbar colors

* iOS DarkMode: Removing background from buttons

* iOS DarkMode warning and unsupported

* iOS DarkMode: MediaPlaceholder

* iOS DarkMode: BottomSheets

* iOS DarkMode: Inserter

* iOS DarkMode: DefaultBlockAppender

* iOS DarkMode: PostTite

* Update hardcoded colors with variables

* iOS DarkMode: Fix bottom-sheet cell value color

* iOS DarkMode: More - PageBreak - Add Block Here

* iOS DarkMode: Better text color

* iOS Darkmode: Code block

* iOS DarkMode: HTML View

* iOS DarkMode: Improve colors on SafeArea

* Fix toolbar not avoiding keyboard regression

* Fix native unit tests

* Fix gutenberg-mobile unit tests

* Adding RNDarkMode mocks

* RNMobile: Fix crash when viewing HTML on iOS

* [RNMobile] Remove toolbar from html view

* [RNMobile] Fix MaxListenersExceededWarning caused by dark-mode event emitter (WordPress#17186)

* Fix MaxListenersExceededWarning caused by dark-mode event emitter

* Checking for setMaxListeners trying to avoid CI error

* Adding remove listener to DarkMode HOC

* DarkMode: Binding this.onModeChanged to `this`

* DarkMode: Adding conditional needed to pass UI Tests on CI

* Fix focus title on new posts regression (WordPress#17180)

* BottomSheet: Setting DashIcon color directly when theme is default (light) (WordPress#17193)
    @etoledom
    etoledom committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    635108e View commit details
    Browse the repository at this point in the history

  2. Activate Travis CI on rnmobile/master branch (WordPress#17229)

    @etoledom
    etoledom committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    643c1b2 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2019

  1. Add native support for the MediaText block (WordPress#16305) 

    * First working version of the MediaText component for native mobile

* Fix adding a block to an innerblock list

* Disable mediaText on production

* MediaText native: improve editor visuals

* Move BlockToolbar from BlockList to Layout

* Remove BlockEditorProvider from BlockList and add native version of EditorProvider to Editor. Plus support InsertionPoint and BlockListAppender

* Update BlockMover for native to hide if locked or if it's the only block

* Make the vertical align button work, add more styling options for toolbar buttons

* Make sure registerCoreBlocks does not break in production

* Copy docblock comment from the web version for registerCoreBlocks

* Fix focusing on the media placeholder

* Only support adding image for now

* Update usage of MediaPlaceholder in MediaContainer

* Enable autoScroll for just the out most block list

* Fix JS Unit tests

* Roll back to IconButton refactor and fix tests

* Fix BlockVerticalAlignmentToolbar buttons style on mobile

* Fix thing for web and ensure ariaPressed is always passed down

* Use AriaPressed directly to style SVG on mobile

* Update snapshots
    @Tug @etoledom
    Tug authored and etoledom committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    a78f204 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2019

  1. MediaUpload and MediaPlaceholder unify props (WordPress#17145)

    @dratwas @koke
    dratwas authored and koke committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    3db95b7 View commit details
    Browse the repository at this point in the history

  2. Unify media placeholder and upload props within media-text (WordPress… 

    …#17268)
    @lukewalczak @pinarol
    lukewalczak authored and pinarol committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    7aa44a2 View commit details
    Browse the repository at this point in the history

  3. [RNMobile] Fix dismiss keyboard button for the post title (WordPress#… 

    …17260)
    @geriux @pinarol
    geriux authored and pinarol committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    f9fa455 View commit details
    Browse the repository at this point in the history

  4. Recover border colors (WordPress#17269)

    @etoledom
    etoledom committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    7b12673 View commit details
    Browse the repository at this point in the history

  5. [RNMobile] Insure tapping at end of post inserts at end 

    Previously, tapping at the end of the post would insert a block
immediately after the currently selected block. In addition, this commit
is cleaning out a few unusued props in the block-list file.
    @mchowning
    mchowning committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    14d482b View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2019

  1. Support group block on mobile (WordPress#17251) 

    * First working version of the MediaText component for native mobile

* Fix adding a block to an innerblock list

* Disable mediaText on production

* MediaText native: improve editor visuals

* Move BlockToolbar from BlockList to Layout

* Remove BlockEditorProvider from BlockList and add native version of EditorProvider to Editor. Plus support InsertionPoint and BlockListAppender

* Update BlockMover for native to hide if locked or if it's the only block

* Make the vertical align button work, add more styling options for toolbar buttons

* Make sure registerCoreBlocks does not break in production

* Copy docblock comment from the web version for registerCoreBlocks

* Fix focusing on the media placeholder

* Only support adding image for now

* Update usage of MediaPlaceholder in MediaContainer

* Enable autoScroll for just the out most block list

* Fix JS Unit tests

* Roll back to IconButton refactor and fix tests

* Fix BlockVerticalAlignmentToolbar buttons style on mobile

* Fix thing for web and ensure ariaPressed is always passed down

* Use AriaPressed directly to style SVG on mobile

* Update snapshots

* Support group block on mobile

* Extend shouldShowInsertionPoint condition to be false when group is selected

* Code refactor

* Update package-lock
    @lukewalczak @pinarol
    lukewalczak authored and pinarol committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    89664eb View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2019

  1. Remove redundant bg color within button appender (WordPress#17325)

    @lukewalczak @pinarol
    lukewalczak authored and pinarol committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    fc8c3da View commit details
    Browse the repository at this point in the history

  2. [RNMobile] DarkMode improvements (WordPress#17309) 

    * Remove the need to import `useStyle` and pass the theme prop on every instance that `withStyle` is used

* Implement dark-mode refactor on all components

* Fix broken native tests

* Fix default block appender background color on DarkMode

* DarkMode: Make `useStyle` a class function
    @etoledom
    etoledom committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    264b178 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2019

  1. Add FloatingToolbar component

    @lukewalczak
    lukewalczak committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    654e162 View commit details
    Browse the repository at this point in the history

  2. Add visible overflow to flat list wrapper

    @lukewalczak
    lukewalczak committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    111059c View commit details
    Browse the repository at this point in the history

  3. Remove useless codelines

    @lukewalczak
    lukewalczak committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    89ed4d7 View commit details
    Browse the repository at this point in the history

  4. Update test

    @lukewalczak
    lukewalczak committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    900233d View commit details
    Browse the repository at this point in the history

  5. Trigger CI

    @lukewalczak
    lukewalczak committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    2deb517 View commit details
    Browse the repository at this point in the history

  6. Remove redundant conditions

    @lukewalczak
    lukewalczak committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    6106f27 View commit details
    Browse the repository at this point in the history

  7. Trigger CI

    @lukewalczak
    lukewalczak committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    67c5cca View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2019

  1. add breadcrumbs

    @dratwas
    dratwas committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    6cd7f52 View commit details
    Browse the repository at this point in the history

  2. [RNMobile] Add autosave to mobile apps (WordPress#17329) 

    * [RNMobile] Fix crash when adding separator

* Build: remove global install of latest npm since we want to use the paired node/npm version (WordPress#17134)

* Build: remove global install of latest npm since we want to use the paired node/npm version
* Also update travis to remove --latest-npm flag

* [RNMobile] Try dark mode (iOS) (WordPress#17067)

* Adding dark mode component implemented on list and list block

* Adding DarkMode handling to RichText, ToolBar and SafeArea

* Mobile: Using DarkMode as HOC

* iOS DarkMode: Modified colors on block list and block container

* iOS DarkMode: Improved Header Toolbar colors

* iOS DarkMode: Removing background from buttons

* iOS DarkMode warning and unsupported

* iOS DarkMode: MediaPlaceholder

* iOS DarkMode: BottomSheets

* iOS DarkMode: Inserter

* iOS DarkMode: DefaultBlockAppender

* iOS DarkMode: PostTite

* Update hardcoded colors with variables

* iOS DarkMode: Fix bottom-sheet cell value color

* iOS DarkMode: More - PageBreak - Add Block Here

* iOS DarkMode: Better text color

* iOS Darkmode: Code block

* iOS DarkMode: HTML View

* iOS DarkMode: Improve colors on SafeArea

* Fix toolbar not avoiding keyboard regression

* Fix native unit tests

* Fix gutenberg-mobile unit tests

* Adding RNDarkMode mocks

* RNMobile: Fix crash when viewing HTML on iOS

* [RNMobile] Remove toolbar from html view

* [RNMobile] Fix MaxListenersExceededWarning caused by dark-mode event emitter (WordPress#17186)

* Fix MaxListenersExceededWarning caused by dark-mode event emitter

* Checking for setMaxListeners trying to avoid CI error

* Adding remove listener to DarkMode HOC

* DarkMode: Binding this.onModeChanged to `this`

* DarkMode: Adding conditional needed to pass UI Tests on CI

* Fix focus title on new posts regression (WordPress#17180)

* BottomSheet: Setting DashIcon color directly when theme is default (light) (WordPress#17193)

* Add a preliminary version of the AutosaveMonitor for mobile that calls the "bridge" and asks the native side to save the content

* Add autosave mock function for tests

* Fix merge conflicts

* Fix lint

* Re-add autosave on mobile that was removed erroneously during import-merge from rnmobile/master

* Remove native variant of AutosaveMonitor and introduces changes at  editor store level

* Default to false for `isEditedPostAutosaveable` on mobile. There was a typo in the returing value on the previous commit.

* Make sure to consider edits to the Title when checking if auto-save is needed

* Fix lint
    @daniloercoli
    daniloercoli committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    648a1b9 View commit details
    Browse the repository at this point in the history

  3. styles tweaks

    @dratwas
    dratwas committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    d0c4b3c View commit details
    Browse the repository at this point in the history

  4. add icon and some tweaks

    @dratwas
    dratwas committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    92b527e View commit details
    Browse the repository at this point in the history

  5. fix typo

    @dratwas
    dratwas committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    e9d0ade View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2019

  1. add subdirectory icon

    @dratwas
    dratwas committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    b4a2a77 View commit details
    Browse the repository at this point in the history

  2. use subdirectory icon

    @dratwas
    dratwas committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    6147e47 View commit details
    Browse the repository at this point in the history

  3. Trigger CI

    @lukewalczak
    lukewalczak committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    9659a73 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2019

  1. Add isAppender functionality on mobile (WordPress#17195) 

    * Add isAppender functionality on mobile

* refactor isAppender conditions

* Replace dropZoneUIOnly in favour of showMediaSelectionUI

* deprecate dropZoneUIOnly and add disableMediaSelection prop

* Update test

* Refactor tests and change prop name

* Remove redundant empty lines

* Refactor conditions inside MediaPlaceholder

* Update block-editor CHANGELOG

* Update packages/block-editor/CHANGELOG.md

Co-Authored-By: Grzegorz (Greg) Ziółkowski <grzegorz@gziolo.pl>
    @lukewalczak @gziolo
    lukewalczak and gziolo committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    e99d365 View commit details
    Browse the repository at this point in the history

  2. Autosave monitor - Make the mobile editor ping the native at each key… 

    …stroke, since the deboucing logic is already well defined in the apps. (WordPress#17548)
    @daniloercoli
    daniloercoli committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    69da85e View commit details
    Browse the repository at this point in the history

  3. [RNMobile] Refactor Dark Mode HOC (WordPress#17552) 

    * [RNMobile] Refactor the Dark Mode HOC to fix naming antipatterns

* Fix lint errors

* Add .native.js suffix to usePreferredColorScheme

* Update usage of theme props renamed to preferredColorScheme

* Update usage of theme props renamed to preferredColorScheme
    @Tug
    Tug committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    ae6d2ce View commit details
    Browse the repository at this point in the history

  4. Add missing heading levels to the UI (H4, H5, H6) (WordPress#17533)

    @SergioEstevao
    SergioEstevao committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    1c9b133 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2019

  1. Fix FloatingToolbar for the first item in FlatList

    @lukewalczak
    lukewalczak committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    8752302 View commit details
    Browse the repository at this point in the history

  2. Small cleanup

    @lukewalczak
    lukewalczak committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    e3a4f1a View commit details
    Browse the repository at this point in the history

  3. Fix lint issue (WordPress#17598)

    @lukewalczak @pinarol
    lukewalczak authored and pinarol committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    df025a6 View commit details
    Browse the repository at this point in the history

  4. Fix list filter on paste for RN mobile. (WordPress#17550) 

    * Fix method for RN mobile.

* Use array.From instead of slice.

* Remove comment and use Array.from directly

* Convert from NodeList spreadable to Array.from

* Fix lint errors.

* Fix documentation examples to use Array.from

* Add empty line.
    @SergioEstevao
    SergioEstevao committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    d8b0d83 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'rnmobile/master' into rnmobile/floating-toolbar

    @lukewalczak
    lukewalczak committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    59f0d5f View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2019

  1. [RNMobile] Move MediaUploadPorgress to its own component folder (Word… 

    …Press#17392)

* Move MediaUploadPorgress to its own component folder (native)

* MediaUploadProgress - Fix import to code standards

* MediaUploadProgress readme

* Mobile - MediaUploadProgress README update
    @geriux @koke
    geriux authored and koke committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    f3085c1 View commit details
    Browse the repository at this point in the history

  2. Working on Android toolbar behaviour

    @lukewalczak
    lukewalczak committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    636bf83 View commit details
    Browse the repository at this point in the history

  3. style fix

    @dratwas
    dratwas committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    b6e9627 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2019

  1. update toolbar background

    @dratwas
    dratwas committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    e51a87c View commit details
    Browse the repository at this point in the history

  2. Rnmobile/fix link editing on start (WordPress#17631) 

    * Don't try to clear links if text is clean.

* Commented LinkUI removal test when no URL.

* Don't try to remove link if we are at start of link and no actual selection is
    @SergioEstevao
    SergioEstevao committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    95acf23 View commit details
    Browse the repository at this point in the history

  3. Small code refactor

    @lukewalczak
    lukewalczak committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    47cd600 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2019

  1. Use temporary solution for first item in group

    @lukewalczak
    lukewalczak committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    6449038 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'rnmobile/master' into rnmobile/floating-toolbar

    @lukewalczak
    lukewalczak committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    d0ba0fe View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into rnmobile/floating-toolbar

    @lukewalczak
    lukewalczak committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    c70edc5 View commit details
    Browse the repository at this point in the history

  4. Merge fix

    @lukewalczak
    lukewalczak committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    300a8a5 View commit details
    Browse the repository at this point in the history

  5. Merge fix

    @lukewalczak
    lukewalczak committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    a9d7489 View commit details
    Browse the repository at this point in the history

  6. Make FloatingToolbar conditional to show flag

    @lukewalczak
    lukewalczak committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    2695248 View commit details
    Browse the repository at this point in the history

  7. Fix after merging

    @lukewalczak
    lukewalczak committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    d2a07ec View commit details
    Browse the repository at this point in the history

  8. Add check for Media&Text block

    @lukewalczak
    lukewalczak committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    e911f5d View commit details
    Browse the repository at this point in the history

  9. Merge branch 'rnmobile/master' into rnmobile/breadcrumbs

    @dratwas
    dratwas committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    89e0790 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'rnmobile/floating-toolbar' into rnmobile/breadcrumbs

    @dratwas
    dratwas committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    e3b3b59 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2019

  1. Merge branch 'master' into rnmobile/breadcrumbs

    @dratwas
    dratwas committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    98ad647 View commit details
    Browse the repository at this point in the history

  2. move icon to separate file

    @dratwas
    dratwas committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    addee65 View commit details
    Browse the repository at this point in the history

  3. fix icon

    @dratwas
    dratwas committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    4d4850a View commit details
    Browse the repository at this point in the history

  4. fix padding

    @dratwas
    dratwas committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    60a77f2 View commit details
    Browse the repository at this point in the history

  5. remove incorrect comment

    @dratwas
    dratwas committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    72d41ef View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into rnmobile/breadcrumbs

    @dratwas
    dratwas committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    171fb82 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. remove unused props and change colors

    @dratwas
    dratwas committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    5646a15 View commit details
    Browse the repository at this point in the history

  2. add dark mode

    @dratwas
    dratwas committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    7e5bab0 View commit details
    Browse the repository at this point in the history