Fix example code in README.md #18158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in WordPress#16916, it seems not to work to add "draggable" attribute directly to Dashicon. The example works when the Dashicon is wrapped in a div.
bastibeckr
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta,
talldan and
youknowriad
as code owners
jorgefilipecosta
approved these changes
Oct 29, 2019
| @@ -53,12 +53,13 @@ const MyDraggable = () => ( | |||
| > | |||
| { | |||
There was a problem hiding this comment.
This "{" and the content inside should be indented one more tab. I added a commit with this fix.
gziolo
added
[Type] Developer Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #16916, it seems not to work to add "draggable" attribute directly to Dashicon. The example works when the Dashicon is wrapped in a div.
Description
How has this been tested?
Screenshots
Types of changes
Checklist: