Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the copy of the Experiments page #18233

Merged
merged 3 commits into from
Dec 17, 2019

Conversation

Copons
Copy link
Contributor

@Copons Copons commented Nov 1, 2019

Description

  • Update the copy and fix the capitalization of the Experiments page.
  • Also adds a note to the Full Site Editing experiment, warning that it's still a WIP feature and could potentially break the site.

Testing instructions

Open /wp-admin/admin.php?page=gutenberg-experiments and make sure it looks fine.

@Copons Copons added [Type] Question Questions about the design or development of the editor. [Feature] Full Site Editing labels Nov 1, 2019
@Copons Copons self-assigned this Nov 1, 2019
@@ -80,7 +80,7 @@ function gutenberg_initialize_experiments_settings() {
'gutenberg-experiments',
'gutenberg_experiments_section',
array(
'label' => __( 'Enable Full Site Editing', 'gutenberg' ),
'label' => __( 'Enable Full Site Editing (Warning: this will break the site)', 'gutenberg' ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option would be to mark it as (Unstable), and then clarify below what it actually means. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho "unstable" doesn't sound dangerous enough 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the warning is now hard to miss. Looks like a good change.

and then clarify below what it actually means.

Perhaps it is worth considering clarifying below what "break the site" means, but I think the warning gets the main point across.

Copy link
Contributor

@Addison-Stavlo Addison-Stavlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il approve for what it's worth. It definitely seems like a good fix to make that warning a bit more apparent while FSE is being developed. It does look like we still have reviews requested from others though.

@talldan
Copy link
Contributor

talldan commented Dec 3, 2019

I see the need for an additional warning, but the current text does seem extreme. I agree that it might be worth elaborating some more on what happens (e.g. 'Warning: this will replace your theme and cause potentially irreversible changes to your site. Please consider using this only in a development environment.')

This has been happening rather frequently on WordPress.com, which threw off track our customer support people that weren't aware of the Full Site Editing experiment.

Maybe WordPress.com needs some more control over whether the experiments are visible or be able to override specific experiments to be disabled using a filter or something similar.

@Copons
Copy link
Contributor Author

Copons commented Dec 3, 2019

@talldan Yup, the copy here was intended as a placeholder to get the discussion going.
I promised to involve some copy review once we decided this was the way to go.
I'll update this with your suggestion and then add the Needs Copy Review label. 👍

Maybe WordPress.com needs some more control over whether the experiments are visible or be able to override specific experiments to be disabled using a filter or something similar.

There are some specific cases in which we might want to leave the experiments available to users.
Normally they are not as disruptive, but the FSE one completely replaces the front end with the (in progress) FSE templates, without any clear indications of what happened.

@Copons Copons force-pushed the update/full-site-editing-experiment-warning branch from 31edab4 to ccb3018 Compare December 13, 2019 13:12
@Copons Copons added the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Dec 13, 2019
@michelleweber
Copy link

michelleweber commented Dec 13, 2019

I like @talldan's wording, and have minor suggestions for that whole area -- some capitalization fixes, some rephrasing.

Experimental settings

The block editor includes experimental features that are useable while they're in development. Select the ones you'd like to enable. These features are likely to change, so avoid using them in production.

  • Enable Widgets screen and Legacy Widgets block
  • Enable Navigation Menu block
  • Enable block directory search
  • Enable Full Site Editing (Note: Warning: this will replace your theme and cause potentially irreversible changes to your site. We recommend using this only in a development environment.)

@Copons
Copy link
Contributor Author

Copons commented Dec 13, 2019

@michelleweber Thanks for the suggestions!
Though it seems you've based them upon the old screenshots I provided in the PR description.

Currently, the Experiment page is like this:

Screenshot 2019-12-13 at 14 41 13

It's not completely different, but a couple of experiments changed.

I can incorporate your suggestions in this PR, so I'm just double checking in case you wish to improve the copy of the new experiments too. 🙂

@michelleweber
Copy link

Ah, gotcha! Yes, there are some small changes, just to capitalization, that we should make in the current copy:

  • Enable Widgets screen and Legacy Widgets block
  • Enable block directory search
  • Enable Full Site Editing (Note: Warning: this will replace your theme and cause potentially irreversible changes to your site. We recommend using this only in a development environment.)
  • Enable Full Site Editing demo templates
  • Enable page templates

@Copons Copons force-pushed the update/full-site-editing-experiment-warning branch from 248a4ea to 6b0c8f6 Compare December 16, 2019 11:38
@Copons Copons changed the title Add an additional warning for the Full Site Editing experiment setting Update the copy of the Experiments page Dec 16, 2019
@Copons Copons removed the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Dec 16, 2019
@Copons Copons requested a review from vindl December 16, 2019 11:41
@Copons
Copy link
Contributor Author

Copons commented Dec 16, 2019

Thanks @michelleweber! I've updated the strings as per your suggestions and removed the Needs Copy Review label. 🙇

Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks @Copons and @michelleweber!

@talldan talldan merged commit 2cb7828 into master Dec 17, 2019
@talldan talldan deleted the update/full-site-editing-experiment-warning branch December 17, 2019 05:56
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
@carlomanf
Copy link

Hi, don't know if this is the right place to ask, but can someone clarify what "potentially irreversible changes" these are referring to?

From what I can tell, everything is reverted back when the FSE is turned off?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Question Questions about the design or development of the editor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants