Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Simplify bridge requestMediaPick methods #18303

Merged
merged 3 commits into from
Nov 14, 2019
Merged

[RNMobile] Simplify bridge requestMediaPick methods #18303

merged 3 commits into from
Nov 14, 2019

Commits on Nov 13, 2019

  1. Merge bridge Requeste media pick methods into a single one, adding … 

    …a source param.

This helps to handle the "others" option in the same way than any other option, plus adding the filters parameter.
This filter parameters is needed for the iOS "Other Apps" media source option.
This is also one step forward to declare all media source options from the client app.
    @etoledom
    etoledom committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    e6a4542 View commit details
    Browse the repository at this point in the history

  2. Move device sources to native bridge component

    @etoledom
    etoledom committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    de85638 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2019

  1. Fix typo on media source name

    @etoledom
    etoledom committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    3de81f4 View commit details
    Browse the repository at this point in the history