Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code block: remove escaping from native file #18369

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Code block: remove escaping from native file #18369

merged 1 commit into from
Nov 7, 2019

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Nov 7, 2019

Description

See #17994. Should be same as web version.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@ellatrix ellatrix requested a review from hypest November 7, 2019 12:42
@SergioEstevao SergioEstevao self-requested a review November 7, 2019 12:53
SergioEstevao
SergioEstevao approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@ellatrix ellatrix merged commit 78c6e86 into master Nov 7, 2019
@ellatrix ellatrix deleted the fix/escape-code-native branch November 7, 2019 13:10
@ellatrix
Copy link
Member Author

ellatrix commented Nov 7, 2019

Thanks for the review!

@youknowriad youknowriad added this to the Gutenberg 6.9 milestone Nov 11, 2019
@hypest hypest mentioned this pull request Nov 11, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

@hypest hypest Awaiting requested review from hypest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gutenberg 6.9
Development

Successfully merging this pull request may close these issues.
3 participants
@ellatrix @SergioEstevao @youknowriad