Rename "Navigation Menu Item" to "Link".

[mtias]

Closes #18521

Revise how we name and refer to navigation items in different places.

[getdave]

I like the idea of making the nomenclature consistent with what a user would expect rather than thinking about this technically as a "child Block of the Nav Menu Block" (which is developer-centric).

Question: is it always the case that the "item" is a link? Or am I splitting hairs here? Could we not have nav items which aren't actually linked and therefore do not technically constitute "links"?

[getdave]

Looks like this will need a rebase now.

@mtias Do you consider this Blocking and do you want someone to take this over for you or will you continue?

[mtias]

Yes, we should settle on names here before switching the experimental flag off.

[shaunandrews]

Seems to me that we should not assume an item within the Navigation block will be a link. It’s a fairly common (even if not recommended) pattern to use a non-link item to create a group within a Navigation. To me, “Menu Item” seems obvious.

[mtias]

pattern to use a non-link item to create a group within a Navigation

A non-link item should likely be a different block — paragraph, heading, etc.

[retrofox]

A non-link item should likely be a different block — paragraph, heading, etc.

So the idea to render in the front-end an item which doesn't have defined a link with an <span> element doesn't make sense. #18442

We need to re-define the behavior and workflow for the nav menu. Wondering for instance how to switch between the Nav Item to another block (paragraph, heading, etc) according to whether the item has defined a link or not.

[shaunandrews]

A non-link item should likely be a different block — paragraph, heading, etc.

How would you add a different block? We don’t show the block inserter anymore, we just add the menu item block. As @retrofox mentions, I guess we could do some magic to change the block depending on if it has a link, but that seems very opaque and confusing.

[obenland]

How would you add a different block? We don’t show the block inserter anymore, we just add the menu item block.

For now the navigation only allows one type of inner block, so there's no need for a selector. Once support for other types of blocks gets added, I'd anticipate the selector to come back.

[obenland]

I think that should cover it! Next up: core/navigation-menu => core/navigation.