Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation: Drop menu suffix #18551

Merged
merged 7 commits into from
Nov 19, 2019
Merged

Navigation: Drop menu suffix #18551

merged 7 commits into from
Nov 19, 2019

Conversation

obenland
Copy link
Member

@obenland obenland commented Nov 15, 2019 •
edited by retrofox
Loading

Helps with minimizing the "menu" confusion for users and reestablishes hierarchy with core/navigation-link.

Fixes #18549 .

How has this been tested?

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@obenland obenland added [Block] Navigation Affects the Navigation Block [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Task Issues or PRs that have been broken down into an individual action to take labels Nov 18, 2019
@retrofox retrofox marked this pull request as ready for review November 18, 2019 18:29
@retrofox retrofox requested review from retrofox and removed request for Soean and ntwb November 18, 2019 18:29
@obenland obenland mentioned this pull request Nov 18, 2019
Merged
6 tasks
getdave
getdave reviewed Nov 19, 2019
View reviewed changes
Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this manually and I couldn't find any references to "menu" remaining. Looking good.

retrofox
retrofox approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@retrofox retrofox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it looks good to me 🚢

@retrofox retrofox merged commit 24fbb35 into master Nov 19, 2019
@noisysocks noisysocks mentioned this pull request Nov 21, 2019
Closed
12 tasks
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
@aristath aristath deleted the update/navigation branch November 10, 2020 14:22
@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getdave getdave getdave left review comments

@retrofox retrofox retrofox approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@nerrad nerrad Awaiting requested review from nerrad

@talldan talldan Awaiting requested review from talldan

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

@draganescu draganescu Awaiting requested review from draganescu

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

@mtias mtias Awaiting requested review from mtias

Assignees
No one assigned
Labels
[Block] Navigation Affects the Navigation Block [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
Gutenberg 7.0
Development

Successfully merging this pull request may close these issues.

Navigation: Rename to core/navigation
4 participants
@obenland @retrofox @getdave @youknowriad