Fixes e2e test failures via console log exception to handle temp wpnonce error
#19532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> [DOM] Found 2 elements with non-unique id #_wpnonce: (More info: https://goo.gl/9p2vKq) This error was getting logged to console when running e2e tests locally and causing my tests to fail. It’s a known issue with WordPress: https://core.trac.wordpress.org/ticket/23165. This commit adds a new condition to console log exception handling to ensure console logs containing this message are ignored and do not trigger test failures. See also https://wordpress.slack.com/archives/C02QB2JS7/p1578578973183100
getdave
added
[Type] Bug
getdave
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
6 tasks
aduth
approved these changes
Jan 9, 2020
aduth
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error was getting logged to console when running e2e tests locally and causing my tests to fail. It’s a known issue with WordPress:
https://core.trac.wordpress.org/ticket/23165.
This commit adds a new condition to console log exception handling in e2e tests to ensure console logs containing this message are ignored and do not trigger test failures.
See also https://wordpress.slack.com/archives/C02QB2JS7/p1578578973183100 (requires registration)
Originally committed here.
How has this been tested?
Difficult to test but requires running the e2e tests.
Best way is to check out this branch and run the e2e tests. You will see that the e2e tests pass when code from this PR is added and they fail when it is removed.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: