Block: remove tabbable inserter button #19594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
ajitbohra,
nerrad,
ntwb,
talldan and
youknowriad
as code owners
|
Why abandon the idea? |
|
@youknowriad Sorry, new PR at #19596. Turns out not many people know about buttons under "More options" and this button may be useful to some people. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unblocks #19322.
This PR removes the tabbable inserter button, since we already have two more descriptive buttons right next to it. It is a few more presses, but the goal was to eventually move this button before the selected block toolbar, so that would be even more presses away. Additionally, every block has
Enterhandling on the block wrapper to insert a block after the currently selected one.In the future we could add tabbable, visually hidden, inserter button before and after the selected block if easier access is wanted. Before
How has this been tested?
Screenshots
Types of changes
Checklist: