Remove Popover from LinkControl component #19638
Conversation
youknowriad
requested review from
ajitbohra,
ellatrix,
jorgefilipecosta,
Soean and
talldan
as code owners
youknowriad
added
[Type] Code Quality
| } ) } | ||
| onClose={ () => setIsLinkOpen( false ) } | ||
| /> | ||
| <Popover> |
There was a problem hiding this comment.
Does it not need a position here?
There was a problem hiding this comment.
It seemed to work without it, maybe it was the default, I'll check.
There was a problem hiding this comment.
I restored this
There was a problem hiding this comment.
Sounds good
Checked with https://github.com/WordPress/gutenberg/pull/19638/files?utf8=✓&diff=unified&w=1
| className={ classnames( 'block-editor-link-control', className ) } | ||
| onClose={ closeLinkUI } | ||
| position="bottom center" | ||
| focusOnMount="firstElement" |
There was a problem hiding this comment.
Are these props no longer needed?
There was a problem hiding this comment.
They seem unnecessary in my testing.
| return; | ||
| } | ||
|
|
||
| function ConnectedLinkControl( props ) { |
There was a problem hiding this comment.
I don't like that I had to do that to make unit tests pass (test the unconnected component). Ideally, we'd find a way to easily mock useSelect
There was a problem hiding this comment.
I don't like that I had to do that to make unit tests pass (test the unconnected component). Ideally, we'd find a way to easily mock useSelect
Follow-up at #19705
youknowriad
added
[Block] Buttons
| label: label || escape( newTitle ), | ||
| opensInNewTab: newOpensInNewTab, | ||
| } ) } | ||
| onClose={ () => setIsLinkOpen( false ) } |
There was a problem hiding this comment.
This should have been moved to the Popover. LinkControl no longer has an onClose prop with the changes from this pull request.
Fix at: #19885
We should be able to use LinkControl outside of Popover.
Testing instructions