Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch social link icons to import svg parts from primitives #19877

Merged
merged 2 commits into from
Feb 3, 2020

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented Jan 24, 2020

Description

Switches Social Link icon imports to use @wordpress/primitives

How has this been tested?

Built, confirmed icons still show in inspector as expected.

Types of changes

Minor change switching import to use new primitives package introduced in #19781

@mkaz mkaz added the [Block] Social Affects the Social Block - used to display Social Media accounts label Jan 24, 2020
@mkaz mkaz added the Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code label Jan 28, 2020
@mkaz mkaz force-pushed the update/social-icons-primitives branch from 5dfacec to e3384bf Compare January 31, 2020 14:50
@mkaz mkaz force-pushed the update/social-icons-primitives branch from e3384bf to 523cf97 Compare February 1, 2020 14:14
Copy link
Member

@ajitbohra ajitbohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mkaz mkaz merged commit 2f6e7fd into master Feb 3, 2020
@mkaz mkaz deleted the update/social-icons-primitives branch February 3, 2020 22:08
@github-actions github-actions bot added this to the Gutenberg 7.5 milestone Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants