Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social Link: group all variations under one block type #19887

Merged
merged 9 commits into from
Feb 6, 2020
Merged

Social Link: group all variations under one block type #19887

merged 9 commits into from
Feb 6, 2020

Commits on Feb 4, 2020

  1. Social Link: group all variations under one block type

    @mcsf
    mcsf committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    febaaff View commit details
    Browse the repository at this point in the history

  2. Social Link: Update test fixtures

    @mcsf
    mcsf committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    c5a0da2 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2020

  1. Address review feedback

    @mcsf
    mcsf committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    38eacaa View commit details
    Browse the repository at this point in the history

  2. Fix misnamed attribute 'type' -> 'site'

    @mcsf
    mcsf committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    52071b0 View commit details
    Browse the repository at this point in the history

  3. Social Link: Rename attribute 'site' to 'service'

    @mcsf
    mcsf committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    ba9070f View commit details
    Browse the repository at this point in the history

  4. Social Link: Update description

    @mcsf
    mcsf committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    586da71 View commit details
    Browse the repository at this point in the history

  5. Change attribute name to service (previously site)

    @mkaz
    mkaz committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    74c7987 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2020

  1. Lint: Equal sign alignment

    @mkaz
    mkaz committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    d1b6347 View commit details
    Browse the repository at this point in the history

  2. Social Link: Remove unnecessary block deprecation 

    This PR introduces `core/social-link` as a new block type. Strictly
speaking, any concerns of backwards compatibility should only deal with
the migration of `core/social-link-FOO` types to this new one --
something that the parser is handling directly, populating the new
`service` attribute in that process.

Thus, no specific provisions are needed for the extant but obsolete
`site` attribute: the attribute will be silently dropped during block
validation. This can be attested by loading any content with links in
the old `core/social-link-FOO` shape.
    @mcsf
    mcsf committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    07a9e36 View commit details
    Browse the repository at this point in the history