Fix fixture serialization with double newline ending #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Build Tooling
…ures Conflicts: blocks/test/fixtures/core__latest-posts.json
|
Looks good & works well for me. I also used this PR to test out a configuration change to code coverage reporting, add a new test fixture, and fix a bug in the test suite that I noticed while doing so. |
nylen
approved these changes
Jul 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2056
Related: #2034 (cc @nylen)
This pull request seeks to...
In #2034, the test for valid serialized output was updated to include a newline at the end. However, the newline appending should have been removed from the subsequent output writing. Currently there are two newlines:
https://github.com/WordPress/gutenberg/blob/cec69e8/blocks/test/full-content.js#L170
https://github.com/WordPress/gutenberg/blob/cec69e8/blocks/test/full-content.js#L175
This pull request removes the latter of these.
Testing instructions:
Verify that running the (newly-introduced) fixtures generate scripts result in no changes or test failures: