Chore: Use useResizeObserver from compose instead of useResizeAware #20897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Code Quality
|
Is this a duplicate of #20889 |
|
Size Change: -377 B (0%) Total Size: 856 kB
ℹ️ View Unchanged
|
|
Oh sorry, I noticed this improvement while working on other changes and did not notice we already had a PR, closing this PR. |
aduth
deleted the
chrore/useResizeObserver-from-compose-instead-of-useResizeAware
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses useResizeObserver instead of useResizeAware directly on the web both hooks reference the same code but on mobile, we have a compatibility layer at useResizeObserver so I guess we should use it.