Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert post title instead of URL, when adding a link to an existing post #21240

Merged
merged 4 commits into from
Apr 1, 2020
Merged

Insert post title instead of URL, when adding a link to an existing post #21240

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f13eba
Fix for #11930
pwkip Mar 29, 2020
e292cad
Fix long titles
pwkip Mar 31, 2020
4a9bc5d
Add test to check link to existing post
pwkip Apr 1, 2020
226a010
small change in naming
pwkip Apr 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/format-library/src/link/inline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,13 @@ function InlineLinkUI( {
} );

if ( isCollapsed( value ) && ! isActive ) {
const newText =
nextValue.hasOwnProperty( 'title' ) && nextValue.title !== ''
pwkip marked this conversation as resolved.
Show resolved Hide resolved
? nextValue.title
: newUrl;

const toInsert = applyFormat(
create( { text: newUrl } ),
create( { text: newText } ),
format,
0,
newUrl.length
Expand Down