Initial attempt to split storybook stories into separate snapshots #21484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentswisher
added
[Type] Automated Testing
|
Size Change: 0 B Total Size: 889 kB ℹ️ View Unchanged
|
gziolo
reviewed
Apr 10, 2020
| return currentElement; | ||
| }, | ||
| } ) ), | ||
| integrityOptions: { cwd: __dirname }, // it will start searching from the current directory |
There was a problem hiding this comment.
This mocking logic is essential to make tests pass when components use createRef.
There was a problem hiding this comment.
Yes, I was waiting to see which direction #21485 went before spending more time getting all the tests running correctly. I didn't want to spend the time if the decision is to drop storyshots altogether.
There was a problem hiding this comment.
we can always make those snapshots more useful but adding additional assertions like running a11y checks on the generated content.
|
Interesting exploration 👍 |
|
Should it be closed now that we are removing StoryShots? 😃 |
|
Yes, was just waiting for that to be merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in Progress
Description
Updates the storybook add-on story shots to save snapshots in separate stories for each component.
Due to what appears to be an unfixed bug in story shots, each story will also have to export
parameters: { fileName: __filename },How has this been tested?
Screenshots
Types of changes
Checklist: