-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Coding Guidelines: Add "gotchas" section about ES2020 optional chaining #22029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Size Change: -3.84 kB (0%) Total Size: 821 kB
ℹ️ View Unchanged
|
sainthkh
approved these changes
May 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
ajlende
reviewed
May 5, 2020
Co-authored-by: Alex Lende <ajlende@gmail.com>
Related ESLint rule proposal: #22041 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #21967 (comment), #21984, #21853
This pull request seeks to add a section to the JavaScript Coding Guidelines, with the purpose to outline a few common pitfalls to be wary of when using the newly-supported ES2020 optional chaining language feature.
► Read documentation
Testing Instructions:
As the only changes affect documentation, it is not expected there should be any impact on the runtime behavior of the application.