Card: Enhance CardHeader and CardFooter with Flex #22916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update enhances the CardHeader and CardFooter sub-components of Card with the new layout-based Flex component. This improves the alignment of child content for common header/footer use-cases. The various Card `README.md` files were updated to reflect the changes.
ItsJonQ
requested review from
ajitbohra,
chrisvanpatten and
jorgefilipecosta
as code owners
|
Size Change: +37 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
|
@ItsJonQ I tested and indeed it works perfectly. My only concern is that this would break at least some places where |
|
@adamziel Thank you for testing! 🙏
I feel like it should be okay. Although of course, I cannot confirm 100%. cc'ing @nerrad + @jameskoster to double check 😊 |
adamziel
approved these changes
Jun 8, 2020
|
@psealock @jeffstieler @mattsherman y'all have been using this component in the Woo Home Screen work I believe. |
|
@psealock @jeffstieler @mattsherman 👋 Hallo!! Just a quick follow up 😊 Thanks! |
We are, but I don't think that should be a blocker to progress. Thanks for the heads up. |
|
@psealock Awesome! I'll merge it up |
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Screenshot of CardHeader with content +
<Button />aligned)This update enhances the CardHeader and CardFooter sub-components of Card with the new layout-based Flex component. This improves the alignment of child content for common header/footer use-cases.
The various Card
README.mdfiles were updated to reflect the changes.Lastly, a new
space()style utility was added to help generatepxvalues that follow the8pxgrid systemhttps://make.wordpress.org/design/2019/10/31/proposal-a-consistent-spacing-system-for-wordpress/
This update was originally inspired from #22827 (review)
cc'ing @adamziel for sanity check!
How has this been tested?
Tested locally on Storybook.
npm run storybook:devcardheaderAlignmentexampleChecklist: