Avoid overriding popover content padding #23270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
youknowriad
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
etoledom,
SergioEstevao,
Soean and
talldan
as code owners
|
Size Change: +82 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
update/avoid-setting-padding-popover-content
branch
from
8defec4
to
2725dea
Compare
youknowriad
force-pushed
the
update/avoid-setting-padding-popover-content
branch
from
2725dea
to
52645c5
Compare
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's very unfortunate that we need to override the padding of popovers by targetting the internal
popover__content(or its direct descendent) div. Ideally a user of the Popover component shouldn't be touching this div at all. That said, that's already there.For the moment I just avoid touching the "padding" directly cause this messes up with the height calculations.