Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix template part switching instability #23282

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Fix template part switching instability #23282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
994e533
Fix template part switching instability
youknowriad Jun 18, 2020
c2df665
Fix heading block instability
youknowriad Jun 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/e2e-tests/specs/editor/blocks/heading.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,13 @@ describe( 'Heading', () => {
it( 'it should correctly apply custom colors', async () => {
await clickBlockAppender();
await page.keyboard.type( '### Heading' );
const [ colorPanelToggle ] = await page.$x(
const colorPanelToggle = await page.waitForXPath(
COLOR_PANEL_TOGGLE_X_SELECTOR
);
await colorPanelToggle.click();

const [ customTextColorButton ] = await page.$x(
`${ CUSTOM_COLOR_BUTTON_X_SELECTOR }`
const customTextColorButton = await page.waitForXPath(
CUSTOM_COLOR_BUTTON_X_SELECTOR
);

await customTextColorButton.click();
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/specs/experiments/template-part.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ describe( 'Template Part', () => {
await page.click(
'.components-dropdown-menu__toggle[aria-label="Switch Template"]'
);
const [ switchToHeaderTemplatePartButton ] = await page.$x(
const switchToHeaderTemplatePartButton = await page.waitForXPath(
'//button[contains(text(), "header")]'
);
await switchToHeaderTemplatePartButton.click();
Expand Down