Use a more specific <script> matching

[dd32]

Description

Uses a more specific matching pattern to only affect the <script> tags which we're interested in.
This should resolve the issues in #23158

This uses the full <script> produced by WP_Scripts::do_item() ignoring the Translations and before/after inline scripts, which allows for it to exclude <script% tags contained within the before/after html chunks.

The major change I see here after testing is two fold:

1. Script tags in the JSON are not altered
2. The sub-scripts of wp-polyfill no longer get data-handle elements, as they're not built the same way, where they previously were, eg:

( 'fetch' in window ) || document.write( '<script src="https://example.site/wp-includes/js/dist/vendor/wp-polyfill-fetch.min.js?ver=3.0.0"></scr' + 'ipt>' );

I'm unsure if this is a concern, as I don't believe scripts should be depending on individual wp-polyfill-* scripts and only the main polyfill library?

How has this been tested?

As in #23158

• Activate the Block experiment in Gutenberg -> Experiments and Yoast at the same time.
• Verify that the editor does not WSOD
• Verify that the HTML source contains data-handle attributes on appropriate script tags.
• Visual diff comparison of the source of post-new.php comparing before/after.

Types of changes

Bug Fix.

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.

[gziolo]

@Djennez can you confirm it solves the issue? We can include it in the Gutenberg plugin release later today.

[gziolo]

@noisysocks, it would be great to include this fix in the plugin release today.

[tellyworth]

This is a smart solution, much quicker than the regex idea. It worked for me in testing.