Popover: allow scrolling over #23696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
ellatrix
commented
Jul 4, 2020
| @@ -396,8 +391,7 @@ const Popover = ( { | |||
| setAnimateOrigin( animateXAxis + ' ' + animateYAxis ); | |||
| }; | |||
|
|
|||
| // Height may still adjust between now and the next tick. | |||
| const timeoutId = window.setTimeout( refresh ); | |||
There was a problem hiding this comment.
Height is now continuously calculated since #23159.
|
Size Change: -983 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
fix/popover-position-scroll
branch
3 times, most recently
from
317543f
to
8006b36
Compare
ellatrix
force-pushed
the
fix/popover-position-scroll
branch
2 times, most recently
from
501a97d
to
96c0434
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables scrolling the content while the pointer is over the block toolbar.
This PR reverts #19896. That fix is no longer necessary since popover height is no longer only calculated once (#23159) and the position is set with
useLayoutEffect(#23312), meaning we can set the popover top/left styles as soon as the component renders.How has this been tested?
Screenshots
Types of changes
Checklist: