Try List View in a panel in post editor #25034
Conversation
talldan
added
the
[Feature] List View
talldan
changed the title
|
Size Change: +686 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
ZebulanStanphill
added
the
Needs Accessibility Feedback
|
This shows a lot of promise. Once we get the design updates #24029 (and #24419) and fix the "moves focus which closes the panel" thing, this could be very helpful for complex documents and the Site Editor.
I noticed an empty descender; I'm assuming its something do to with the + button and the fact that the selected block doesn't supper InnerBlocks. |
|
@shaunandrews Good spot, I think we need to check whether the block supports an appender before showing the descender. We can add that to the todo list! I've started separately working on some performance improvements in #25069. |
|
Noting that this PR replicates the new Inserter sidebar pattern, which has been already identified as an accessibility regression compared to the previous implementation. See #22858 Further a11y testing of the Inserter sidebar is still pending, as there are other issues to evaluate and address, see #24975. Overall, I'd think this needs a serious, in depth, accessibility testing to understand if it's a good pattern for all users and I'd kindly ask to wait for testing to happen even if it could take a while because the accessibility team has scarce availability of time and resources. Specific issues I noticed at a very first look of this implementation:
|
|
Would be really helpful seeing this PR ready for WP 5.6. Huuuuge win. |
There was a problem hiding this comment.
A first accessibility feedback was given in #25034 (comment)
Also, the accessibility team is not fully convinced the "sidebar" pattern is good for accessibility in the first place. The team had an initial discussion on this but didn't come to a conclusion yet.
|
Quick consideration related to reordering. I guess blocks that can be reordered horizontally (e.g. buttons, social icons) should display the mover buttons arranged horizontally and with left/right chevron icons. Right now, they use up/down icons:
Example of left/right reorder button icons in the block toolbar:
|
|
Thinking a bit more in depth to this "List View" pattern, I'm very, very, hesitant on the idea of changing the Block navigator to a more complex UI, especially if extra features like Movers, More menu, etc. are added to it. The original intent of the Block navigator is to provide users with a simple navigation tool to navigate through the blocks. To some extent, this also helps keyboard and screen reader users. Making it a complex UI that lives in a Sidebar (a pattern that has its own accessibility issues) and provides way more controls that are difficult to understand and navigate defeats the purpose of having a simple navigational tool. For more background, see my comment on this related issue #22113 (comment) |
What an interesting thought. 80/20 All the way to Pareto. I as a user really don't need more: Being able to move blocks more easily - with the navigator (many pagebuilders do that). For big posts this would be an ENORmous help and I think the sense behind it doesn't need to be discussed anymore. I as a user would be completely satisfied with arrows and drag and drop. |
I'm not sure I understand whether that's irony or sarcasm, also because I'm not a native English speaker. Either ways, I'm not sure that language and tone is appropriate. I'd like to point out again that the Block navigator was designed to solve an accessibility problem amongst other things. `s such, it's a tool that keyboard users and assistive technologies users need to be as simple as possible with no extra features that would defeat its purpose by making it harder to use for these users. |
@afercia Oops - no, I did not want to convey that at all. I meant it seriously. And the Pareto principle is quite effective and efficient. As I understood you, you suggested not to include so many options and to use only the most important ones. Please excuse me if I am wrong here. So I wanted to say: Your idea is really good and I as an end user do not need more. eddit: maybe that was due to my bad English (I am from Germany). If that is the case: Sorry again ;) |
|
Don't worry, @afercia, I'm a native English speaker, and I didn't understand it either. 😛 As someone who was initially completely in favor of adding a bunch of new controls to List View and making it a sidebar (comparing it to stuff like Divi's Layers View), I think it's important to note that I See my response to the aforementioned comment on #22113. In short, I now favor exploring the introduction of a new "Move mode" or perhaps even a "List mode", both of which would simply change the appearance and available block controls of the main editor canvas... rather than trying to solve problems through a complementary sidebar interface (which has the downsides of limited space, divided attention between it and the main canvas, and a multitude of keyboard navigation issues). |
|
Could we all just keep things civil here. The code of conduct for the project states that "We strive to maintain a welcoming environment where everyone can feel included", and that includes overcoming misunderstandings. You can just ask for clarification if you don't understand something rather than instantly assuming the worst intent. @ZebulanStanphill I appreciate your thoughts, but I don't really understand why you'd write something like this:
That's not a very collaborative approach. I really wouldn't be very happy to see this kind of comment on a new contributor's issue or PR. That's designed to throw a roadblock down rather than work constructively to find a better solution. |
|
Good point. I've reworded my comment. |
|
Testing the PR. Giving some general feedback in relation to the Nav list view. I added the Nav block. Selected to add the top level pages. One thing that I do not think have been mentioned earlier is the opportunity to click into the name similar to Mac/Windows to rename the text of a link. Meaning in the Nav screen and nav block click into the menu item to first select and then click into the name again to open the field for renaming of menu item. |
|
Closing this down, as I don't have time to work on this currently. List View has already been added to the site editor in the same way as this, so it may be that the work there is replicated in the post editor at some point. That implementation has already surpassed this one, so I don't think there's any value in keeping this around. |
Description
This is a very quick attempt at moving List View into a side panel in the post editor, as described in #22113. It also enables some of the List View features that have only been in the experiemental navigation editor:
At the moment there seems to be performance issues for some reason.
Also noting that selecting a block moves focus which closes the panel.
How has this been tested?
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: