Support custom units on theme.json #25217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
Customization
youknowriad
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
mkaz,
spacedmonkey and
TimothyBJacobs
as code owners
|
The dev note is needed because it's opt-out now. |
11 tasks
|
Size Change: +34 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
|
@youknowriad Reviewing now! 🙏 |
ItsJonQ
approved these changes
Sep 15, 2020
There was a problem hiding this comment.
@youknowriad Amazing! Moving things to the theme.json way is a breath of fresh air. Tested this locally, and it is working. I tried both disabling, adding custom units, and using just the default settings.
It was helpful for me to see the conversion of add_theme_supports to the new editorFeature method via theme.json.
Thanks a bunch!
aristath
approved these changes
Sep 15, 2020
3 tasks
5 tasks
youknowriad
removed
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #20588
Alternative to #24873
Similar to #24761 but for custom units.
The idea of this PR is to support configuring custom unit support from theme.json.
Testing instructions
spacing.unitspath.custom-unitstheme support flag.