[Widgets] Try inserting intermediate sub-sections in widgets customizer #25434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Feature] Widgets Screen
|
Size Change: +76 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
adamziel
reviewed
Sep 18, 2020
packages/edit-widgets/src/index.js
Outdated
Comment on lines
53
to
57
| if ( ! registered ) { | ||
| registerCoreBlocks(); | ||
| if ( process.env.GUTENBERG_PHASE === 2 ) { | ||
| __experimentalRegisterExperimentalCoreBlocks( settings ); | ||
| } |
There was a problem hiding this comment.
We'll also need registerBlock( legacyWidget ); as in line 33 in the same file. Maybe it's time to that logic into our own registerWidgetsEditorBlocks() function?
|
I left a minor note but otherwise looks good - keep up the good work! |
kevin940726
force-pushed
the
update/sub-sections-in-widgets-customizer
branch
from
c6f5363
to
61beeca
Compare
|
Blocked by #25625 |
|
No longer needed, see #23975 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to fix #23975.
This PR is an attempt to add intermediate sub-sections to Widgets customizer. This PR still suffers from several issues including #25157, #25154, and #25201.
Still unable to get it working as expected though. The goal is to add the
widget-areablock to the editor, currently I'm adding the inner blocks of thewidget-areablock. However, I can't seem to find a way to add only onewidget-areablock to the editor? What am I missing and how should I fix this?How has this been tested?
Screenshots
Types of changes
New feature
Checklist: