core-data: use builtin data controls instead of deprecated data-controls ones #25772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +35 B (0%) Total Size: 1.18 MB
ℹ️ View Unchanged
|
jsnajdr
force-pushed
the
migrate/core-data-builtin-controls
branch
from
4c192d8
to
88fb916
Compare
nerrad
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #25362 that removes the deprecated
data-controlscontrols from thecore-datapackage. ExceptapiFetch, we use only the builtinselectandresolveSelectcontrols.The patch to
ifNotResolvedhelper deserves special attention: it used to callselect( 'core', 'hasFinishedResolution' ), which in thedata-controlsversion does internally__experimentalResolveSelect, i.e., waits for the resolver resolution. But thehasFinishedResolutionselector never has any resolver: we want to read the value synchronously. Therefore, as the straightforward replacement would beresolveSelect, I'm fixing a little bug (not observable anyway) by using the synchronousselectcontrol.