Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled: Use CSS-in-JS #25843

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Disabled: Use CSS-in-JS #25843

merged 1 commit into from
Oct 23, 2020

Conversation

sarayourfriend
Copy link
Contributor

Description

This PR updates the Disabled component to use CSS-in-JS similar to how newer components do like the AnglePickerControl and Text.

How has this been tested?

I've compared the before and after in storybook and there are neither visual nor behavior differences between the this and what currently exists.

Screenshots

Before:
Captura de Tela 2020-10-05 às 13 22 43

After:
Captura de Tela 2020-10-05 às 13 22 52

Types of changes

Non-breaking changes. The classnames are preserved so consumers are still able to target and pass classnames to the styled element.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Copy link

@ItsJonQ ItsJonQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 from me!! Thank you @saramarcondes

@ItsJonQ ItsJonQ merged commit c33f007 into WordPress:master Oct 23, 2020
@github-actions github-actions bot added this to the Gutenberg 9.3 milestone Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants