-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table block: use hooks + API v2 #26065
Conversation
Size Change: -851 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
6a64429
to
55b677e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work properly for me.
@talldan might want to take a look here?
Table has e2e tests and everything should still be the same. The interesting thing to rewrite here was having a method as a component, which could be avoided by just having the children in a map on render. |
Looks good, some nice improvements to the code! I did some fairly thorough testing and couldn't spot any issues. |
Thanks! |
Description
How has this been tested?
Screenshots
Types of changes
Checklist: