-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spinner: Use CSS-in-JS #26433
Merged
Merged
Spinner: Use CSS-in-JS #26433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
October 23, 2020 22:27
Size Change: +135 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
sarayourfriend
force-pushed
the
refactor/use-css-in-js-for-spinner
branch
2 times, most recently
from
October 26, 2020 21:23
6146233
to
5aeda3b
Compare
sarayourfriend
force-pushed
the
refactor/use-css-in-js-for-spinner
branch
from
October 27, 2020 15:10
5aeda3b
to
3902e5a
Compare
ItsJonQ
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 from me! Refactors look good. Tested it locally in Storybook as well in local Gutenberg. The Spinner is rendering and animating correctly :)
Thank you @saramarcondes !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use CSS-in-JS for
Spinner
.How has this been tested?
Verified to work in storybook.
Types of changes
Non-breaking change. Existing classnames are preserved allowing existing targeting of the component to work.
Checklist: