Site editor: Fix e2e tests navigation panel

[david-szabo97]

Description

Change template name in E2E to match the current naming.

Types of changes

Bug fix

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.

[jeyip]

Do we want to update the "Front page" string in packages/e2e-tests/specs/experiments/multi-entity-saving.test.js:209 as well?

[jeyip]

I ran both tests locally. The multi-entity editing test is still passing 🎉 I'm curious though -- did you happen to run into any problems with Template Part › Template part block › Should load customizations when in a template even if only the slug and theme attributes are set. returning a 404 error?

I'm pretty certain the issue is something with my local testing environment because of the nature of the error and the fact that it's passing without issue in Github Actions, but I was wondering if you saw anything similar.

Either way, +1 when my question about "Front page" in multi-entity-saving.test.js is resolved.

[david-szabo97]

Do we want to update the "Front page" string in packages/e2e-tests/specs/experiments/multi-entity-saving.test.js:209 as well?

Gotcha! Updated that as well. Thanks!

I ran both tests locally. The multi-entity editing test is still passing 🎉 I'm curious though -- did you happen to run into any problems with Template Part › Template part block › Should load customizations when in a template even if only the slug and theme attributes are set. returning a 404 error?

E2E tests aren't working for me locally at all 😄

[github-actions]

Size Change: 0 B

Total Size: 1.2 MB

ℹ️ View Unchanged

Filename	Size	Change
build/a11y/index.js	1.14 kB	0 B
build/annotations/index.js	3.53 kB	0 B
build/api-fetch/index.js	3.34 kB	0 B
build/autop/index.js	2.73 kB	0 B
build/blob/index.js	664 B	0 B
build/block-directory/index.js	8.58 kB	0 B
build/block-directory/style-rtl.css	943 B	0 B
build/block-directory/style.css	942 B	0 B
build/block-editor/index.js	130 kB	0 B
build/block-editor/style-rtl.css	11 kB	0 B
build/block-editor/style.css	11 kB	0 B
build/block-library/editor-rtl.css	8.93 kB	0 B
build/block-library/editor.css	8.93 kB	0 B
build/block-library/index.js	146 kB	0 B
build/block-library/style-rtl.css	7.75 kB	0 B
build/block-library/style.css	7.75 kB	0 B
build/block-library/theme-rtl.css	741 B	0 B
build/block-library/theme.css	741 B	0 B
build/block-serialization-default-parser/index.js	1.78 kB	0 B
build/block-serialization-spec-parser/index.js	3.1 kB	0 B
build/blocks/index.js	47.6 kB	0 B
build/components/index.js	172 kB	0 B
build/components/style-rtl.css	15.3 kB	0 B
build/components/style.css	15.3 kB	0 B
build/compose/index.js	9.62 kB	0 B
build/core-data/index.js	12.1 kB	0 B
build/data-controls/index.js	679 B	0 B
build/data/index.js	8.61 kB	0 B
build/date/index.js	31.8 kB	0 B
build/deprecated/index.js	769 B	0 B
build/dom-ready/index.js	571 B	0 B
build/dom/index.js	4.42 kB	0 B
build/edit-navigation/index.js	10.7 kB	0 B
build/edit-navigation/style-rtl.css	881 B	0 B
build/edit-navigation/style.css	885 B	0 B
build/edit-post/index.js	306 kB	0 B
build/edit-post/style-rtl.css	6.37 kB	0 B
build/edit-post/style.css	6.35 kB	0 B
build/edit-site/index.js	22.2 kB	0 B
build/edit-site/style-rtl.css	3.79 kB	0 B
build/edit-site/style.css	3.79 kB	0 B
build/edit-widgets/index.js	26.6 kB	0 B
build/edit-widgets/style-rtl.css	3.09 kB	0 B
build/edit-widgets/style.css	3.09 kB	0 B
build/editor/editor-styles-rtl.css	480 B	0 B
build/editor/editor-styles.css	482 B	0 B
build/editor/index.js	42.6 kB	0 B
build/editor/style-rtl.css	3.85 kB	0 B
build/editor/style.css	3.84 kB	0 B
build/element/index.js	4.44 kB	0 B
build/escape-html/index.js	735 B	0 B
build/format-library/index.js	7.47 kB	0 B
build/format-library/style-rtl.css	547 B	0 B
build/format-library/style.css	548 B	0 B
build/hooks/index.js	1.74 kB	0 B
build/html-entities/index.js	623 B	0 B
build/i18n/index.js	3.55 kB	0 B
build/is-shallow-equal/index.js	712 B	0 B
build/keyboard-shortcuts/index.js	2.38 kB	0 B
build/keycodes/index.js	1.84 kB	0 B
build/list-reusable-blocks/index.js	3.01 kB	0 B
build/list-reusable-blocks/style-rtl.css	476 B	0 B
build/list-reusable-blocks/style.css	476 B	0 B
build/media-utils/index.js	5.11 kB	0 B
build/notices/index.js	1.69 kB	0 B
build/nux/index.js	3.26 kB	0 B
build/nux/style-rtl.css	671 B	0 B
build/nux/style.css	668 B	0 B
build/plugins/index.js	2.44 kB	0 B
build/primitives/index.js	1.35 kB	0 B
build/priority-queue/index.js	790 B	0 B
build/redux-routine/index.js	2.85 kB	0 B
build/reusable-blocks/index.js	3.06 kB	0 B
build/rich-text/index.js	13 kB	0 B
build/server-side-render/index.js	2.6 kB	0 B
build/shortcode/index.js	1.69 kB	0 B
build/token-list/index.js	1.24 kB	0 B
build/url/index.js	4.05 kB	0 B
build/viewport/index.js	1.74 kB	0 B
build/warning/index.js	1.14 kB	0 B
build/wordcount/index.js	1.22 kB	0 B

_{compressed-size-action}

[jeyip]

E2E tests aren't working for me locally at all 😄

Is your current workflow to wait for github actions jobs to pass? 😿

If you ever need evaluated quickly, feel free to ping me if you see me online. I'm happy to checkout your branches for a little bit and run tests locally until you you get your e2e testing environment ironed out 🙂

[Addison-Stavlo]

These axe-core error failures look unrelated as they seem to be happening on all PRs currently. It looks like the axe is having problems injecting into the iframe / block previews (and does it even make sense for it to be since it is a disabled preview in the first place). 🤔

[Addison-Stavlo]

Also noting that the changes like 'Front Page' don't seem to fix any failures that I am able to reproduce locally or seeing on current CI checks? 🤔 These e2e's are a pain.

[david-szabo97]

Is your current workflow to wait for github actions jobs to pass? 😿

Yes 😅

If you ever need evaluated quickly, feel free to ping me if you see me online. I'm happy to checkout your branches for a little bit and run tests locally until you you get your e2e testing environment ironed out 🙂

Thank you! I will ping you next time!

Also noting that the changes like 'Front Page' don't seem to fix any failures that I am able to reproduce locally or seeing on current CI checks? 🤔 These e2e's are a pain.

I saw an E2E test fail on one of the PRs that said it can't find the Front page template. So I thought this might fix that 😄 AFAIK XPath contains is case sensitive so it would make sense for those tests to fail.

[Addison-Stavlo]

I saw an E2E test fail on one of the PRs that said it can't find the Front page template. So I thought this might fix that 😄 AFAIK XPath contains is case sensitive so it would make sense for those tests to fail.

Yeah. I have seen that before as well. I cant get consistent results from either CI or local though, which is strange. You think it would fail consistently? Either way, the changes here still make sense to me.

[david-szabo97]

I think it should fail consistently, since XPath is case sensitive. But I can't say it for sure since E2E tests are kinda unreliable 😅

[jeyip]

I think it should fail consistently, since XPath is case sensitive.

I wasn't able to have it fail in my local environment. I do, however, remember seeing the failure that you're describing pop up non-deterministically (it resolved itself on a rerun).

I agree with Addie. I'd expect this spec to fail consistently as well. The changes make sense either way, and my hope is that they solve the non-deterministic failures.

[Copons]

Changes make sense to me.