Storybook: fix broken BlockDraggable story #26457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
force-pushed
the
fix/block-draggable-story
branch
from
8f0c4ad
to
08d80d0
Compare
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a story for the
BlockDraggableChipcomponent that is currently broken:There were several issues, ordered by most serious first:
{ BlockDraggableChip }. That'sundefinedthough.clientIdsis the only required, others (label,icon) are not supported at all. I'm providing array with two dummy IDs, to avoid needing to create and populate acore/block-editorstoredivwith 24px margin is needed. Without that, the negative margins will shift the component partially out of view.The result after the patch:
