Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the image block's zoom slider width #27285

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Fix the image block's zoom slider width #27285

merged 1 commit into from
Nov 26, 2020

Conversation

stokesman
Copy link
Contributor

@stokesman stokesman commented Nov 26, 2020 •
edited
Loading

Description

To fix #27126. Which seems to have been a result of #25218. The previous min-width was 260px so that's what's been applied here.

How has this been tested?

  1. Add an image block and upload/choose an image from the media library
  2. Click the Crop button
  3. Click the Zoom button
  4. Observe the dropdown is wide enough so that the slider/range input is usable

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

talldan
talldan approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice one! Thanks for fixing.

@talldan talldan merged commit 86977ae into WordPress:master Nov 26, 2020
@github-actions github-actions bot added this to the Gutenberg 9.5 milestone Nov 26, 2020
@talldan talldan changed the title Give the Image block zoom popover min-width Fix the image block's zoom slider width Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan talldan approved these changes

@ajlende ajlende Awaiting requested review from ajlende

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gutenberg 9.5
Development

Successfully merging this pull request may close these issues.

Image block zoom range input is zero width and unusuable
2 participants
@stokesman @talldan