-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix locked template not updating when inner blocks template prop changes #28007
Conversation
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
}; | ||
|
||
registerBlockType( 'test/test-inner-blocks-no-locking', { | ||
registerBlockType('test/test-inner-blocks-no-locking', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason prettier isn't working on these files. I tried the npm run format-js
command as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is a major blocker for the PR.
I had a brief look and couldn't see why this is happening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#28033 has background and restores formatting and linting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the "Test Inner Blocks update locked template" and it works as described. Thanks!
Thanks for the review! |
Thank you talldan for taking the time to resolve my concern. I look forward to the fix in the version hopefully in the 5.6.1 minor release. Thank you again. Kind regards, |
Description
Fixes #27897
Adds a missing dependency to ensure template sync update works correctly.
It looks like when this was refactored to a hook the dependency was missed.
How has this been tested?
Added an e2e test.
To manually test:
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: