-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try: Visual regression test coverage for Cover block #28554
Open
ockham
wants to merge
19
commits into
trunk
Choose a base branch
from
add/visual-diff-testing
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+218
−4
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
469a4df
First stab
ockham 786e6bb
Setup
ockham ff81d6b
Add jest-image-snapshot as a root devDep
ockham 62262a4
Don't create new post for each test
ockham 0ee29cd
Revert "Don't create new post for each test"
ockham c17bc10
Upload image
ockham 2c191fb
Cover Block, not Image :facepalm:
ockham d0546fc
Select Cover block rather than child block
ockham 9475aa8
Add image snapshot
ockham 35f769c
Default jest-image-snapshot settings seem to do the trick
ockham 2d243ca
Store diffs in artifacts dir
ockham b1d96c5
Add frontend test
ockham 5c24f3a
Rename image snapshots/diffs
ockham fcfbab0
No need to store screenshots to disk
ockham e11dff5
Use same selector in editor and frontend
ockham e4debfb
Add TODO note
ockham 272eaf1
Enter some text content for Cover block
ockham 5311460
Unselect the cover block (to remove the 'selected' highlight frame).
ockham fbf92c4
Try disabling font render hinting
ockham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
/** | ||
* External dependencies | ||
*/ | ||
import { configureToMatchImageSnapshot } from 'jest-image-snapshot'; | ||
|
||
const root = process.env.GITHUB_WORKSPACE || process.cwd(); | ||
const ARTIFACTS_PATH = root + '/artifacts'; | ||
|
||
function slugify( testName ) { | ||
const slug = testName | ||
.toLowerCase() | ||
.replace( /:/g, '-' ) | ||
.replace( /[^0-9a-zA-Z \-\(\)]/g, '' ) | ||
.replace( / /g, '-' ); | ||
return slug; | ||
} | ||
|
||
// All available options: https://github.com/americanexpress/jest-image-snapshot#%EF%B8%8F-api | ||
const toMatchImageSnapshot = configureToMatchImageSnapshot( { | ||
customDiffDir: ARTIFACTS_PATH, | ||
customSnapshotIdentifier: ( { currentTestName } ) => | ||
slugify( currentTestName ), | ||
} ); | ||
|
||
// Extend Jest's "expect" with image snapshot functionality. | ||
expect.extend( { toMatchImageSnapshot } ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+6.6 KB
...ditor/blocks/__image_snapshots__/cover-renders-correctly-in-the-editor-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.18 KB
...tor/blocks/__image_snapshots__/cover-renders-correctly-on-the-frontend-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied from https://github.com/WordPress/wordpress-develop/pull/209/files#diff-336f082d49a2a791f40cd4448439e5ffa0610df1731bb62959908823a727555b 😄