Add do_block_template_part function #30345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
added
[Feature] Themes
|
Size Change: +380 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Thanks for exploring this! I think it'd be a nice way to gradually turn parts of a theme into block parts. Should we have more specific functions for semantic template parts (header and footer at the moment)? |
Makes sense... Added |
mtias
reviewed
Apr 1, 2021
|
Would it be possible to adapt |
|
Yes, it would be possible, but only after Gutenberg gets merged in core. But I'm not sure if it would be better or not 🤔 |
|
One advantage I can see is that it would mean that block themes would work even if the site editor wasn't enabled. |
|
One more note on naming, since these functions don't take content directly (like |
Good point. Renamed them, removing the |
5 tasks
|
I followed the testing instructions and it is working well for me. It did get me thinking about if it would be reasonable to add the header and footer HTML elements as wrappers, |
carolinan
approved these changes
Apr 7, 2021
I was looking at function gutenberg_block_template_part( $attributes ) {
echo do_blocks( sprintf( '<!-- wp:template-part %s /-->', json_encode( $attributes ) ) );
}
The concept I shared above, resolves the issue as well when the There are more benefits because it fully aligns the handling for the block with how it works in different contexts:
|
2 tasks
aristath
added a commit
to aristath/q
that referenced
this pull request
May 6, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
gutenberg_do_block_template_part()function. This can be used by classic (non-FSE) themes that want to use a block template for their header and/or footer.How has this been tested?
block-template-parts/header.htmlfile from the TT1-Blocks theme to twentytwentyoneheader.phpfile replace this line:<?php get_template_part( 'template-parts/header/site-header' ); ?>with this:<?php gutenberg_block_header_area(); ?>Your theme will now use the block-template instead of the PHP template for the header.
Checklist:
*.native.jsfiles for terms that need renaming or removal).cc @mtias