Block API: Adding a Block API flag to disable the block's HTML mode #3037
Conversation
youknowriad
added
[Feature] Block API
|
In my testing, using your instructions, this works for me 👍 👍 |
| @@ -34,7 +35,7 @@ function BlockSettingsMenuContent( { mode, uids, isSidebarOpened, onDelete, onTo | |||
| > | |||
| { __( 'Settings' ) } | |||
| </IconButton> | |||
| { count === 1 && | |||
| { count === 1 && blockType && blockType.supportHTML !== false && | |||
There was a problem hiding this comment.
Is count === 1 redundant here, since blockType assumes a single selected block anyways?
| import { removeBlocks, toggleSidebar, setActivePanel, toggleBlockMode } from '../actions'; | ||
|
|
||
| function BlockSettingsMenuContent( { mode, uids, isSidebarOpened, onDelete, onToggleSidebar, onShowInspector, onToggleMode, onClose } ) { | ||
| export function BlockSettingsMenuContent( { blockType, mode, uids, isSidebarOpened, onDelete, onToggleSidebar, onShowInspector, onToggleMode, onClose } ) { |
There was a problem hiding this comment.
Should we consider splitting props onto their own lines, since this one is now quite long? Alternatively, would it be sensible to create a separate component solely responsible for deciding whether and how an "Edit as HTML" button should be rendered?
There was a problem hiding this comment.
would it be sensible to create a separate component solely responsible for deciding whether and how an "Edit as HTML" button should be rendered?
Sounds like a good idea
| import { toggleBlockMode } from '../actions'; | ||
|
|
||
| export function BlockModeToggle( { blockType, mode, onToggleMode } ) { | ||
| if ( blockType.supportHTML === false ) { |
There was a problem hiding this comment.
Unsure how defensive we should be here, i.e. what if blockType is null, or in getBlock( state, uid ).name the property accesses on null? Not likely to ever occur, but would be destructive if it did.
youknowriad
force-pushed
the
add/block-api-disable-html
branch
from
e4ab3d7
to
162c423
Compare
closes #2985
This PR adds a
supportHTMLblock type property to remove support for the HTML mode. The idea is to fix this issue before the next release.Notes
We could consider to infer this from blocks returning
nullin the save function but this is not consistent, Some dynamic blocks can decide to provide fallback HTML and some static blocks could returnnulldepending on some attributes.We need to start thinking about unifying all the
support*flags under a unique property?Testing instructions