Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: Improve VisualEditorBlock rendering of settings menu #3202

Merged
merged 2 commits into from
Oct 27, 2017

Conversation

aduth
Copy link
Member

@aduth aduth commented Oct 27, 2017

Related: #2934

This pull request seeks to...

  • Update the imported name of the BlockSettingsMenu component to match its exported name
  • Remove an unhandled focus prop not managed by the BlockSettingsMenu component

Testing instructions:

Verify there are no regressions in the behavior of the block right menu, particularly for multi-selection.

@aduth aduth added the [Feature] Blocks Overall functionality of blocks label Oct 27, 2017
@aduth aduth requested a review from ellatrix October 27, 2017 13:40
@codecov
Copy link

codecov bot commented Oct 27, 2017

Codecov Report

Merging #3202 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3202   +/-   ##
=======================================
  Coverage   31.56%   31.56%           
=======================================
  Files         221      221           
  Lines        6311     6311           
  Branches     1121     1121           
=======================================
  Hits         1992     1992           
  Misses       3631     3631           
  Partials      688      688
Impacted Files Coverage Δ
editor/modes/visual-editor/block.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d951c5f...69f515c. Read the comment docs.

@aduth aduth merged commit 40147c7 into master Oct 27, 2017
@aduth aduth deleted the update/block-right-menu branch October 27, 2017 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant