Pattern Directory API: Pass through the pattern's blockTypes to support pattern transforms #32113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryelle
added
the
[Feature] Pattern Directory
|
Size Change: 0 B Total Size: 1.86 MB ℹ️ View Unchanged
|
ryelle
force-pushed
the
update/pattern-api-blocktypes
branch
from
26ae61e
to
453bee1
Compare
iandunn
previously approved these changes
May 24, 2021
|
Core uses |
|
Since this is used directly by the JS, I thought it better to keep it |
|
Yeah it should still be |
|
ahh, I see. Okay, I'll make the change back to snake_case. |
ryelle
force-pushed
the
update/pattern-api-blocktypes
branch
2 times, most recently
from
053aa21
to
ea1e36e
Compare
|
I've updated the PR to use |
ryelle
force-pushed
the
update/pattern-api-blocktypes
branch
2 times, most recently
from
5fdc488
to
05011d4
Compare
ryelle
force-pushed
the
update/pattern-api-blocktypes
branch
from
e14f54c
to
4bedabf
Compare
|
This PR has been updated since it was originally created - now it updates the Patterns API response using filters, so that it will affect both the core endpoint in 5.8+, and the GB endpoint on older sites. It adds a I also noticed that the |
ryelle
force-pushed
the
update/pattern-api-blocktypes
branch
from
4bedabf
to
c4881c0
Compare
|
Updated this PR to apply to the new Featured category of patterns as well. Still only the "Heading" and "Quote" patterns have |
ryelle
dismissed
iandunn’s stale review
There have been changes since this approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In WordPress/pattern-directory#111, we added a
blockTypesproperty to patterns in the Pattern Directory. This is returned in the API endpointhttp://api.wordpress.org/patterns/1.0/as an array inmeta.wpop_block_typesfor each pattern.This PR updates the local endpoint to pass through that
blockTypesproperty and use it when registering remote blocks.See #28800
How has this been tested?
/wp-json/wp/v2/pattern-directory/patternsblock_typespropertyThe quote block also has a pattern transform if you want to test that too :)