-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Reusable block save button, snackbar on save and Welcome Guide #32464
Closed
thisissandip
wants to merge
22
commits into
WordPress:trunk
from
thisissandip:add/snackbar-and-guide-with-resuable-block-save-button
Closed
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
8bc50d4
Add Reusable block save button, snackbar on save and Welcome Guide
thisissandip fd391bd
Update the way to check dirty records and Fix l10n
thisissandip afe9922
Remove External Link and Update Finish Button Text in Welcome Gudie
thisissandip 424fbc9
Move Save Button to it's own group
thisissandip a4f9b21
move hasEdits to top useSelect
thisissandip 297e62e
Fix ESLint Errors
thisissandip ea6ef3a
rebase
thisissandip 38fbea7
Add welcome guide image
thisissandip 355595a
welcome guide updates and make save button to 32px in height
thisissandip 1046bc4
Save button box inset
thisissandip 35e713b
fix typos and add css comments
thisissandip a0ab538
add dot to parent selector for reusable block
thisissandip da40570
Add dot to block parent seletor and reusable block toolbar
thisissandip 1952b92
add two separate components for unsaved changes indicator
thisissandip cd7bca8
undo block switcher changes
thisissandip 0df63a4
hide save btn when there are no changes
thisissandip 2a213ee
Merge pull request #1 from thisissandip/add/dot-to-parent-selector
thisissandip 74fcdd6
update label and adjust margin
thisissandip f038b11
use grid-unit-10
thisissandip 6e5b545
adjust unsaved changes indicator margin
thisissandip bf3eaf9
increase parent selector focus indicator width
thisissandip 740a109
gets rid of visual jump
kellychoffman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use $grid-unit-10 instead of 8px if you like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, Yes! Thank you! 😄