Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid generic function names for page list block internal functions #32736

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Avoid generic function names for page list block internal functions #32736

merged 1 commit into from
Jun 16, 2021

Conversation

youknowriad
Copy link
Contributor

Addresses #28265 (comment)

I'm not sure these are the best names but I tried renaming these functions so they don't look as generic WP APIs and more internal functions used by the block's server side code.

@youknowriad youknowriad added [Type] Code Quality Issues or PRs that relate to code quality Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta [Block] Page List Affects the Page List Block labels Jun 16, 2021
@youknowriad youknowriad self-assigned this Jun 16, 2021
ntsekouras
ntsekouras approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any alternative proposal for the names, but these are pretty self explanatory about their scope.

Thanks Riad!

mcsf
mcsf approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what I had in my workdir. :)

@mcsf mcsf merged commit ab76d9d into trunk Jun 16, 2021
@mcsf mcsf deleted the update/page-list-block-function-names branch June 16, 2021 14:36
@github-actions github-actions bot added this to the Gutenberg 10.9 milestone Jun 16, 2021
@youknowriad youknowriad removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 21, 2021
youknowriad added a commit that referenced this pull request Jun 21, 2021
@youknowriad
Avoid generic function names for page list block internal functions (#…
deae5d4 
…32736)
@youknowriad youknowriad mentioned this pull request Jun 21, 2021
Merged
youknowriad added a commit that referenced this pull request Jun 21, 2021
@youknowriad
Avoid generic function names for page list block internal functions (#…
9b348db 
…32736)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcsf mcsf mcsf approved these changes

@ntsekouras ntsekouras ntsekouras approved these changes

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@youknowriad youknowriad

Labels
[Block] Page List Affects the Page List Block [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 10.9
Development

Successfully merging this pull request may close these issues.
3 participants
@youknowriad @mcsf @ntsekouras