Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery block refactor: remove the imageCount attribute #33677

Merged
merged 4 commits into from
Jul 26, 2021
Merged

Gallery block refactor: remove the imageCount attribute #33677

merged 4 commits into from
Jul 26, 2021

Commits on Jul 26, 2021

  1. Remove the imageCount attribute and use CSS instead to set default co… 

    …lumns
    Glen Davies committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    8586af7 View commit details
    Browse the repository at this point in the history

  2. remove unneeded calc

    Glen Davies committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    f1d7616 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary nested calcs and fix lint error

    @aaronrobertshaw
    aaronrobertshaw committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    427065f View commit details
    Browse the repository at this point in the history

  4. * Add optional chaining to innerBlockImages in edit wrapper in case i… 

    …t is not defined

* Move setting of default columns class to classNames call to avoid confusing the type of columns var
    Glen Davies committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    ba7ffcd View commit details
    Browse the repository at this point in the history