Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @wordpress/components package's contributing guidelines #33960

Merged
merged 35 commits into from
Sep 9, 2021
Merged

Update @wordpress/components package's contributing guidelines #33960

merged 35 commits into from
Sep 9, 2021

Commits on Sep 8, 2021

  1. README: add notes

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    7e93e07 View commit details
    Browse the repository at this point in the history

  2. README: add link to CONTRIBUTING.md

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    37e1759 View commit details
    Browse the repository at this point in the history

  3. CONTRIBUTING: Add initial notes

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    cefad1f View commit details
    Browse the repository at this point in the history

  4. More notes into CONTRIBUTING

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    02114ce View commit details
    Browse the repository at this point in the history

  5. Update CONTRIBUTING

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    3d665fb View commit details
    Browse the repository at this point in the history

  6. Add enable to boolean prefixes

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    0fb4753 View commit details
    Browse the repository at this point in the history

  7. Remove View suffix for styled components

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    00e2b35 View commit details
    Browse the repository at this point in the history

  8. Update folder structure: move styles and types into each subfolder

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    17ccabe View commit details
    Browse the repository at this point in the history

  9. Less strict working about typescript, rename PolymorphicComponent to … 

    …WordPressComponent
    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    1459214 View commit details
    Browse the repository at this point in the history

  10. Update packages/components/CONTRIBUTING.md 

    Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
    @ciampo @gziolo
    ciampo and gziolo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    c6f6a24 View commit details
    Browse the repository at this point in the history

  11. Refer to the repo testing overview docs in the unit test section

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    f533857 View commit details
    Browse the repository at this point in the history

  12. Update polyfill info

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    4c1c200 View commit details
    Browse the repository at this point in the history

  13. Remove "Components Structure" paragraph

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    89a89d1 View commit details
    Browse the repository at this point in the history

  14. Reword text in "Folder structure" section, exclude shared utilities

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    5238a88 View commit details
    Browse the repository at this point in the history

  15. Folder structure schemes: name parent folders, remove useless sub-com… 

    …ponent folder
    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    7acc925 View commit details
    Browse the repository at this point in the history

  16. Expand Storybook section

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    6621f1e View commit details
    Browse the repository at this point in the history

  17. Add details to soft deprecation strategy

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    6f6d8de View commit details
    Browse the repository at this point in the history

  18. Misc smaller improvements

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    9d0ece7 View commit details
    Browse the repository at this point in the history

  19. Fix typo

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    d394f5d View commit details
    Browse the repository at this point in the history

  20. Expand hooks vs components section, move under composition

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    3359502 View commit details
    Browse the repository at this point in the history

  21. Move sub components naming convention under "APIs consistency" section

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    cfc843d View commit details
    Browse the repository at this point in the history

  22. Add Polymorphic components sub-section, reorganise "Components compos… 

    …ition" section into sub-sections
    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    abf50ad View commit details
    Browse the repository at this point in the history

  23. Add more details about listing props through knobs in storybook

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    0021dfc View commit details
    Browse the repository at this point in the history

  24. Remove hyphen from subcomponents

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    15f7023 View commit details
    Browse the repository at this point in the history

  25. Add content to the Context System section

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    4520f7e View commit details
    Browse the repository at this point in the history

  26. comment out unfinied sections

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    95de8fb View commit details
    Browse the repository at this point in the history

  27. Apply suggestions from code review 

    Co-authored-by: Haz <hazdiego@gmail.com>
Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
    @ciampo @diegohaz @gziolo
    3 people committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    5393b9a View commit details
    Browse the repository at this point in the history

  28. Comment out reference to the "composition section"

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    6647446 View commit details
    Browse the repository at this point in the history

  29. Rename "Emotion" section to "Styling"

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    670ca6c View commit details
    Browse the repository at this point in the history

  30. Updale unit test section to link directly to components snapshot testing

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    e65518d View commit details
    Browse the repository at this point in the history

  31. Update the storybook section, adding more details on stories and knobs

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    b6edc2e View commit details
    Browse the repository at this point in the history

  32. Link to the Coding Guidelines in the "Documentation" section

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    e8bb18d View commit details
    Browse the repository at this point in the history

  33. remove note about relevance of SCSS-related docs in README

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    08cd356 View commit details
    Browse the repository at this point in the history

  34. Update context section with example snippets

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    c34f731 View commit details
    Browse the repository at this point in the history

  35. Format internal links to absolute path format

    @ciampo
    ciampo committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    8c494c8 View commit details
    Browse the repository at this point in the history