Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Toolbar & Popover component - Prevent sticky position from causing permanently obscured areas of the selected block. #33981

Merged
merged 19 commits into from
Aug 25, 2021
Merged

Block Toolbar & Popover component - Prevent sticky position from causing permanently obscured areas of the selected block. #33981

merged 19 commits into from
Aug 25, 2021

Commits on Aug 10, 2021

  1. try using next block as anchor

    @Addison-Stavlo
    Addison-Stavlo committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    2e279f5 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. place popover below block if available when sticky

    @Addison-Stavlo
    Addison-Stavlo committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    cbdfbed View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2021

  1. if starts at bottom of block, keep there

    @Addison-Stavlo
    Addison-Stavlo committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    0ad2b7e View commit details
    Browse the repository at this point in the history

  2. fix edge cases

    @Addison-Stavlo
    Addison-Stavlo committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    db79917 View commit details
    Browse the repository at this point in the history

  3. add bottom sticky position

    @Addison-Stavlo
    Addison-Stavlo committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    c9bedde View commit details
    Browse the repository at this point in the history

  4. fix jumpy bug on using toolbar

    @Addison-Stavlo
    Addison-Stavlo committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    284f5d9 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. revert to default behavior as soon as there is room. no bottom sticky… 

    … necessary
    @Addison-Stavlo
    Addison-Stavlo committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    2306fce View commit details
    Browse the repository at this point in the history

  2. refactor logic and comment

    @Addison-Stavlo
    Addison-Stavlo committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    9efdfdb View commit details
    Browse the repository at this point in the history

  3. remove unnecessary else

    @Addison-Stavlo
    Addison-Stavlo committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    b7ea822 View commit details
    Browse the repository at this point in the history

  4. gross selectors

    @Addison-Stavlo
    Addison-Stavlo committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    0499cf4 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. pass content wrapper through to popover as prop

    @Addison-Stavlo
    Addison-Stavlo committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    b90c937 View commit details
    Browse the repository at this point in the history

  2. minor refactor

    @Addison-Stavlo
    Addison-Stavlo committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    1308ed9 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2021

  1. use bottom sticky if necessary

    @Addison-Stavlo
    Addison-Stavlo committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    03404b1 View commit details
    Browse the repository at this point in the history

  2. update names, comments, JSDocs

    @Addison-Stavlo
    Addison-Stavlo committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    af1b01b View commit details
    Browse the repository at this point in the history

  3. add basic store tests

    @Addison-Stavlo
    Addison-Stavlo committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    9c30bec View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2021

  1. remove store goo

    @Addison-Stavlo
    Addison-Stavlo committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    169bcbf View commit details
    Browse the repository at this point in the history

  2. use the contentRef

    @Addison-Stavlo
    Addison-Stavlo committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    2c4acb3 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. Merge branch 'trunk' into try/fix-block-toolbar-over-block-content

    @Addison-Stavlo
    Addison-Stavlo committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    4cad802 View commit details
    Browse the repository at this point in the history

  2. Update packages/block-editor/src/components/block-tools/block-popover.js

    @Addison-Stavlo
    Addison-Stavlo committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    010db4c View commit details
    Browse the repository at this point in the history