[Block Library - Query Pagination Next/Previous]: Remove text and link color support #36954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
gziolo,
kjellr,
jasmussen,
ellatrix and
cbravobernal
ntsekouras
added
the
Backport to WP 6.7 Beta/RC
11 tasks
cbravobernal
approved these changes
Nov 29, 2021
I guess it's okay to have separate background colors if we want, because pagination is displayed differently if we apply a background in the parent |
ntsekouras
deleted the
remove/text-link-color-support-from-query-pagination-next-previous
branch
noisysocks
pushed a commit
that referenced
this pull request
Nov 30, 2021
…k color support (#36954) * [Block Library - Query Pagination Next/Previous]: Remove text and link color support * remove extraneous link setting
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/WordPress/gutenberg/pull/36562/files#r758225518
For Query Pagination Next and Previous blocks we had enabled color support for text and link. However these two blocks are always a link and it doesn't make much sense IMO to introduce another wrapper in dom. Now it doesn't work because when we add a
link colorthe selector produced searches childrenaelements to apply the style.This PR proposes to remove the text/link color support from these individual blocks and keep this support in the parent block
Query Paginationblock.